Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export of hidezdecorations! from MakieLayout.jl #2821

Merged
merged 2 commits into from Mar 31, 2023

Conversation

aramirezreyes
Copy link
Contributor

@aramirezreyes aramirezreyes commented Mar 29, 2023

Added export of hidezdecorations!

I wonder if there are unit tests needed for this?

Description

Fixes:

hidezdecorations! is not exported.

Add a description of your PR here.

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

Added export of hidezdecorations!
Added description of change
@aramirezreyes aramirezreyes changed the title Update MakieLayout.jl Add export of hidezdecorations! from MakieLayout.jl Mar 29, 2023
@asinghvi17
Copy link
Member

asinghvi17 commented Mar 30, 2023

Looks good! It would be great to have an example in the docs as well, if possible. Maybe in the Axis3 example page?

@SimonDanisch
Copy link
Member

Thanks!

@SimonDanisch SimonDanisch merged commit 59599fb into MakieOrg:master Mar 31, 2023
12 of 13 checks passed
@aramirezreyes aramirezreyes deleted the patch-1 branch April 7, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants