Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow zero length geometries #2911

Closed
wants to merge 3 commits into from
Closed

Conversation

rafaqz
Copy link
Contributor

@rafaqz rafaqz commented May 3, 2023

Description

Fixes #2819

Checks for zero length everywhere (I could find so far) that geom[1] etc is used.

Should I put tests in conversions.jl?

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch
Copy link
Member

Should I put tests in conversions.jl?

Yes, that'd be lovely :)

@rafaqz
Copy link
Contributor Author

rafaqz commented May 3, 2023

Ok, let me know if those make sense

@SimonDanisch
Copy link
Member

Merged in #2917

@rafaqz rafaqz deleted the allow_zero_length branch May 5, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant plot empty vectors of LineString
2 participants