Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis attribute docs improvements #2940

Merged
merged 19 commits into from May 11, 2023
Merged

Conversation

jkrumbiegel
Copy link
Collaborator

  • title and subtitle
  • titlealign
  • xlabel and ylabel
  • xtrimspine and ytrimspine
  • xaxisposition and yaxisposition
  • remove old aspect docs
  • remove old limits docs
  • limits
  • xscale and yscale
  • add pseudolog
  • pseudolog examples

@MakieBot
Copy link
Collaborator

MakieBot commented May 10, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 9.66s (9.53, 9.76) 0.07+- 1.10s (1.09, 1.12) 0.01+- 757.76ms (742.39, 808.87) 23.10+- 10.39ms (10.28, 10.57) 0.09+- 89.23ms (88.32, 90.45) 0.72+-
master 9.72s (9.60, 9.80) 0.06+- 1.12s (1.11, 1.14) 0.01+- 751.27ms (742.82, 763.08) 6.04+- 10.48ms (10.39, 10.61) 0.07+- 88.42ms (87.91, 89.19) 0.48+-
evaluation -0.64%, -0.06s invariant (-0.90d, 0.12p, 0.07std) -1.45%, -0.02s faster ✓ (-1.33d, 0.03p, 0.01std) +0.86%, 6.49ms invariant (0.38d, 0.50p, 14.57std) -0.87%, -0.09ms invariant (-1.10d, 0.06p, 0.08std) +0.91%, 0.81ms slower X (1.33d, 0.03p, 0.60std)
CairoMakie 8.71s (8.55, 8.90) 0.13+- 1.27s (1.24, 1.32) 0.03+- 266.49ms (258.53, 275.62) 5.37+- 10.61ms (10.42, 10.87) 0.14+- 6.14ms (6.05, 6.26) 0.07+-
master 8.79s (8.68, 8.90) 0.08+- 1.27s (1.23, 1.29) 0.02+- 267.59ms (255.15, 278.20) 7.46+- 10.72ms (10.61, 10.88) 0.09+- 6.17ms (6.11, 6.24) 0.04+-
evaluation -0.93%, -0.08s invariant (-0.75d, 0.19p, 0.11std) +0.17%, 0.0s invariant (0.08d, 0.89p, 0.03std) -0.41%, -1.11ms invariant (-0.17d, 0.76p, 6.42std) -1.06%, -0.11ms invariant (-0.95d, 0.10p, 0.12std) -0.54%, -0.03ms invariant (-0.58d, 0.31p, 0.06std)
WGLMakie 12.72s (12.62, 12.99) 0.15+- 1.66s (1.63, 1.70) 0.02+- 15.16s (15.07, 15.35) 0.11+- 19.60ms (17.80, 21.35) 1.25+- 0.98s (0.94, 1.02) 0.03+-
master 12.81s (12.69, 12.96) 0.12+- 1.71s (1.66, 1.74) 0.03+- 15.10s (15.04, 15.18) 0.05+- 19.07ms (17.86, 20.27) 0.83+- 1019.82ms (946.97, 1217.22) 94.25+-
evaluation -0.73%, -0.09s invariant (-0.69d, 0.22p, 0.13std) -3.30%, -0.05s faster ✓ (-2.34d, 0.00p, 0.02std) +0.41%, 0.06s invariant (0.70d, 0.22p, 0.08std) +2.71%, 0.53ms invariant (0.50d, 0.37p, 1.04std) -4.10%, -0.04s invariant (-0.57d, 0.32p, 0.06std)

@jkrumbiegel jkrumbiegel merged commit be91de1 into master May 11, 2023
14 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/more-block-attr-examples branch May 11, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants