Fix errorbar and bracket interaction with transform functions #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
ffreyer
changed the title
ffreyer
commented
Jun 17, 2023
Comment on lines
+110
to
+115
| # Avoid scale!() / translate!() / rotate!() to affect these | ||
| series!(pl, bp; space = :pixel, solid_color = pl.color, linewidth = pl.linewidth, | ||
| linestyle = pl.linestyle, transformation = Transformation()) | ||
| text!(pl, textpoints, text = texts, space = :pixel, align = pl.align, offset = textoffset_vec, | ||
| fontsize = pl.fontsize, font = pl.font, rotation = autorotations, color = pl.textcolor, | ||
| justification = pl.justification) | ||
| justification = pl.justification, model = Mat4f(I)) |
There was a problem hiding this comment.
Currently space = :pixel still includes model transformation (at least in GLMakie). Since plot_to_screen deals with them now, they'd be included twice. To prevent that I'm overwriting model/transformation. I'm using transformation for series because model doesn't get passed down.
ffreyer
commented
Jun 17, 2023
Comment on lines
-190
to
-191
| whiskers = lift(plot, linesegpairs, scene.camera.projectionview, | ||
| scene.camera.pixel_space, whiskerwidth) do pairs, _, _, whiskerwidth |
There was a problem hiding this comment.
With camera.pixel_space this sometimes fails to update correctly when zooming or resizing. scene.px_area works fine.
jkrumbiegel
approved these changes
Jun 21, 2023
Missing reference imagesFound 1 new images without existing references. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3005 and #1455
I replaced
scene_to_screenandscreen_to_scenewithplot_to_screenandscreen_to_plothere, which includes applying the model matrix, transform function and considersplot.space. I changed the name because these functions are more closely related to what a plot is doing, and a plot can have different transformations (and coordinate space) than a scene.I'm also hoping it trips up CI if I missed some calls to the old functions.This now also fixes some issues with bracket. On master it doesn't react to window resizing and it doesn't include transformations when calculating its positions.
Type of change
Checklist