Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycle color for error and range bars #3230

Merged
merged 1 commit into from Oct 23, 2023

Conversation

ErickChacon
Copy link
Contributor

@ErickChacon ErickChacon commented Sep 14, 2023

Description

Currently error and range bars do not cycle colors. This PR simply allows to cycle colors when using error and range bars.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@ErickChacon ErickChacon changed the title cycle for error and range bars cycle color for error and range bars Sep 16, 2023
@jkrumbiegel
Copy link
Collaborator

Thanks, I think this makes sense. Probably needs to be merged in the next breaking version, though, just in case people relied on the old behavior.

@SimonDanisch SimonDanisch changed the base branch from master to sd/beta-20 October 23, 2023 11:43
@SimonDanisch SimonDanisch merged commit 03ec3b9 into MakieOrg:sd/beta-20 Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants