Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cornerradius attribute to Box #3308

Merged
merged 3 commits into from Oct 23, 2023
Merged

Conversation

jkrumbiegel
Copy link
Collaborator

@jkrumbiegel jkrumbiegel commented Oct 20, 2023

Description

grafik

Type of change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 20, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 14.22s (13.22, 14.70) 0.49+- 1.36s (1.25, 1.40) 0.05+- 1.03s (1.01, 1.05) 0.01+- 12.53ms (11.86, 13.08) 0.36+- 186.70ms (178.19, 190.41) 4.36+-
master 14.04s (13.03, 14.57) 0.49+- 1.39s (1.34, 1.46) 0.05+- 874.19ms (855.97, 897.34) 15.48+- 12.55ms (12.23, 12.85) 0.20+- 185.93ms (183.07, 188.69) 2.16+-
evaluation +1.23%, 0.17s invariant (0.36d, 0.52p, 0.49std) -2.21%, -0.03s invariant (-0.63d, 0.26p, 0.05std) +15.12%, 0.16s slower❌ (10.95d, 0.00p, 0.01std) -0.13%, -0.02ms invariant (-0.05d, 0.92p, 0.28std) +0.41%, 0.76ms invariant (0.22d, 0.69p, 3.26std)
CairoMakie 13.30s (12.79, 13.59) 0.27+- 1.46s (1.32, 1.52) 0.07+- 293.10ms (263.10, 315.52) 20.65+- 14.44ms (14.12, 14.73) 0.26+- 7.95ms (7.79, 8.11) 0.13+-
master 13.47s (13.17, 14.27) 0.37+- 1.53s (1.47, 1.62) 0.05+- 293.25ms (272.07, 318.52) 16.53+- 14.56ms (14.06, 14.91) 0.27+- 8.24ms (8.00, 8.82) 0.28+-
evaluation -1.32%, -0.18s invariant (-0.54d, 0.33p, 0.32std) -4.72%, -0.07s invariant (-1.16d, 0.05p, 0.06std) -0.05%, -0.15ms invariant (-0.01d, 0.99p, 18.59std) -0.80%, -0.12ms invariant (-0.44d, 0.43p, 0.27std) -3.60%, -0.29ms faster ✓ (-1.30d, 0.04p, 0.21std)
WGLMakie 18.12s (15.88, 19.27) 1.24+- 1.52s (1.33, 1.64) 0.11+- 17.39s (15.57, 18.52) 1.02+- 25.03ms (21.48, 34.41) 4.49+- 1.14s (1.09, 1.23) 0.05+-
master 17.71s (16.42, 18.81) 1.05+- 1.58s (1.43, 1.70) 0.10+- 17.38s (16.48, 18.29) 0.65+- 23.30ms (21.87, 24.52) 0.97+- 1.14s (1.07, 1.20) 0.05+-
evaluation +2.25%, 0.41s invariant (0.35d, 0.52p, 1.15std) -4.02%, -0.06s invariant (-0.59d, 0.29p, 0.10std) +0.06%, 0.01s invariant (0.01d, 0.98p, 0.83std) +6.91%, 1.73ms noisy🤷‍♀️ (0.53d, 0.36p, 2.73std) +0.24%, 0.0s invariant (0.05d, 0.92p, 0.05std)

@jkrumbiegel jkrumbiegel merged commit 8d68198 into master Oct 23, 2023
13 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/box-rounded-corners branch October 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants