Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade StableHashTraits #3309

Merged
merged 2 commits into from Oct 23, 2023

Conversation

haberdashPI
Copy link
Contributor

@haberdashPI haberdashPI commented Oct 20, 2023

Description

This bumps StableHashTraits to 1.1 and uses stable_hash(x; version=2), which speeds up hashing by a factor of up to 100 compared to stable_hash(x; verison=1) in the benchmarks I've looked at.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch
Copy link
Member

Nice!! :) Happy to hear that... I did a few benchmarks recently and it did show that this actually was a major performance bottleneck for certain kind of plots!

@SimonDanisch SimonDanisch merged commit c388144 into MakieOrg:master Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants