Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate using AbstractVector as side of ImageLike #3395

Merged
merged 1 commit into from Nov 21, 2023

Conversation

jkrumbiegel
Copy link
Collaborator

Now that we've clearly separated these concepts for 0.20, I think it doesn't make sense anymore to just accept whatever AbstractVector as the side of an ImageLike. Note that 1 .. 10 works and so does 1:10, which might feel correct, but this doesn't have to match the pixel count so it's a source of bugs. And [10, 1] works as wells as [10, 3, 5, 1, 1, 3, 1] which is just really strange.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 21, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.38s (3.36, 3.39) 0.01+- 386.03ms (382.28, 390.43) 2.67+- 618.57ms (472.26, 679.23) 97.27+- 7.38ms (7.22, 7.49) 0.09+- 25.40ms (25.23, 25.60) 0.12+-
master 3.39s (3.36, 3.43) 0.02+- 445.47ms (388.16, 521.54) 67.04+- 670.96ms (651.02, 700.50) 15.81+- 7.40ms (7.29, 7.52) 0.08+- 25.34ms (25.22, 25.56) 0.11+-
evaluation 1.00x invariant, -0.02s (-0.92d, 0.13p, 0.02std) 1.15x noisy🤷‍♀️, -59.44ms (-1.25d, 0.06p, 34.85std) 1.08x noisy🤷‍♀️, -52.39ms (-0.75d, 0.21p, 56.54std) 1.00x invariant, -0.01ms (-0.14d, 0.79p, 0.08std) 1.00x invariant, 0.06ms (0.50d, 0.37p, 0.11std)
CairoMakie 3.00s (2.98, 3.01) 0.01+- 332.27ms (327.84, 335.33) 2.58+- 147.77ms (146.86, 149.70) 1.01+- 7.49ms (7.46, 7.53) 0.02+- 614.44μs (611.36, 617.21) 2.16+-
master 2.98s (2.95, 3.01) 0.02+- 333.01ms (329.60, 336.83) 2.24+- 148.50ms (145.39, 153.08) 2.76+- 7.42ms (7.38, 7.50) 0.05+- 600.38μs (596.70, 602.63) 2.04+-
evaluation 0.99x invariant, 0.02s (1.12d, 0.06p, 0.02std) 1.00x invariant, -0.74ms (-0.30d, 0.58p, 2.41std) 1.00x invariant, -0.73ms (-0.35d, 0.53p, 1.88std) 0.99x slower X, 0.07ms (1.75d, 0.01p, 0.04std) 0.98x slower X, 14.07μs (6.69d, 0.00p, 2.10std)
WGLMakie 3.67s (3.63, 3.70) 0.02+- 335.77ms (330.35, 341.50) 4.54+- 8.79s (8.71, 8.96) 0.09+- 9.97ms (9.46, 12.23) 1.00+- 69.81ms (67.78, 77.01) 3.25+-
master 3.66s (3.63, 3.73) 0.03+- 340.29ms (331.43, 358.18) 11.27+- 8.79s (8.72, 8.98) 0.09+- 9.78ms (9.55, 9.98) 0.18+- 71.72ms (67.07, 79.74) 5.50+-
evaluation 1.00x invariant, 0.01s (0.32d, 0.57p, 0.03std) 1.01x invariant, -4.52ms (-0.53d, 0.35p, 7.91std) 1.00x invariant, -0.0s (-0.03d, 0.96p, 0.09std) 0.98x invariant, 0.19ms (0.26d, 0.64p, 0.59std) 1.03x invariant, -1.91ms (-0.42d, 0.45p, 4.37std)

@SimonDanisch SimonDanisch merged commit 7c40a61 into master Nov 21, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the jk/deprecate-abstractvector-imagelike-side branch November 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants