Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transformation passthrough #3418

Merged
merged 2 commits into from Nov 27, 2023
Merged

fix transformation passthrough #3418

merged 2 commits into from Nov 27, 2023

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Nov 25, 2023

Description

Fixes #3417

Seems like you can't add to passed Attributes through kwargs anymore...

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 25, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.37s (3.35, 3.44) 0.03+- 392.75ms (380.88, 401.48) 9.21+- 468.50ms (463.15, 478.49) 5.08+- 7.43ms (7.39, 7.48) 0.03+- 25.36ms (25.27, 25.60) 0.11+-
master 3.38s (3.36, 3.41) 0.02+- 460.90ms (397.81, 508.88) 58.52+- 474.62ms (464.97, 513.16) 17.17+- 7.41ms (7.34, 7.46) 0.04+- 25.32ms (25.23, 25.45) 0.08+-
evaluation 1.00x invariant, -0.0s (-0.07d, 0.89p, 0.03std) 1.17x faster✅, -68.15ms (-1.63d, 0.02p, 33.87std) 1.01x invariant, -6.12ms (-0.48d, 0.40p, 11.12std) 1.00x invariant, 0.02ms (0.63d, 0.26p, 0.04std) 1.00x invariant, 0.04ms (0.40d, 0.47p, 0.10std)
CairoMakie 3.01s (2.98, 3.03) 0.02+- 327.04ms (323.49, 332.62) 3.01+- 144.97ms (141.90, 150.14) 2.71+- 7.49ms (7.40, 7.59) 0.06+- 604.31μs (598.36, 612.22) 4.65+-
master 3.01s (2.98, 3.04) 0.02+- 325.35ms (318.91, 329.65) 4.18+- 144.49ms (142.11, 147.07) 1.91+- 7.50ms (7.41, 7.73) 0.11+- 599.73μs (593.42, 603.62) 3.51+-
evaluation 1.00x invariant, 0.01s (0.24d, 0.66p, 0.02std) 0.99x invariant, 1.69ms (0.46d, 0.40p, 3.60std) 1.00x invariant, 0.48ms (0.20d, 0.71p, 2.31std) 1.00x invariant, -0.01ms (-0.10d, 0.86p, 0.09std) 0.99x invariant, 4.59μs (1.11d, 0.06p, 4.08std)
WGLMakie 3.66s (3.64, 3.69) 0.02+- 532.50ms (527.62, 539.99) 5.15+- 8.79s (8.73, 8.84) 0.03+- 9.55ms (9.50, 9.67) 0.07+- 71.37ms (67.21, 78.43) 4.68+-
master 3.66s (3.63, 3.67) 0.01+- 542.02ms (523.95, 554.56) 12.42+- 8.78s (8.62, 8.93) 0.11+- 9.94ms (9.48, 11.72) 0.79+- 72.43ms (67.99, 78.28) 4.12+-
evaluation 1.00x invariant, 0.0s (0.00d, 1.00p, 0.02std) 1.02x invariant, -9.53ms (-1.00d, 0.10p, 8.78std) 1.00x invariant, 0.02s (0.19d, 0.74p, 0.07std) 1.04x invariant, -0.39ms (-0.69d, 0.24p, 0.43std) 1.01x invariant, -1.06ms (-0.24d, 0.66p, 4.40std)

@SimonDanisch SimonDanisch merged commit ccf6152 into master Nov 27, 2023
@SimonDanisch SimonDanisch deleted the ff/fix_hvlines branch November 27, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hlinesand vlines do not work well on log10 axis after the v0.20 update
3 participants