Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bracket with vector points but without text #3580

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jkrumbiegel
Copy link
Member

Fixes #3569

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 31, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.50s (3.46, 3.53) 0.02+- 360.25ms (310.37, 398.72) 44.14+- 472.13ms (467.58, 475.08) 2.68+- 7.27ms (7.24, 7.33) 0.03+- 25.59ms (25.50, 25.64) 0.05+-
master 3.49s (3.47, 3.54) 0.02+- 378.71ms (311.31, 418.89) 46.26+- 479.70ms (471.35, 517.41) 16.71+- 7.23ms (7.16, 7.29) 0.04+- 25.62ms (25.52, 25.82) 0.11+-
evaluation 1.00x invariant, 0.02s (0.62d, 0.27p, 0.02std) 1.05x noisy🤷‍♀️, -18.46ms (-0.41d, 0.46p, 45.20std) 1.02x invariant, -7.58ms (-0.63d, 0.28p, 9.70std) 0.99x slower X, 0.04ms (1.19d, 0.05p, 0.04std) 1.00x invariant, -0.04ms (-0.42d, 0.45p, 0.08std)
CairoMakie 3.08s (3.03, 3.17) 0.04+- 325.64ms (320.74, 333.15) 4.14+- 144.19ms (139.77, 159.22) 6.79+- 7.35ms (7.17, 7.71) 0.20+- 607.68μs (602.39, 613.93) 4.65+-
master 3.13s (3.09, 3.28) 0.07+- 336.15ms (322.91, 364.10) 15.14+- 145.26ms (141.19, 154.63) 4.71+- 7.50ms (7.31, 7.73) 0.14+- 599.59μs (593.45, 604.51) 4.51+-
evaluation 1.02x invariant, -0.05s (-0.83d, 0.15p, 0.06std) 1.03x invariant, -10.5ms (-0.95d, 0.12p, 9.64std) 1.01x invariant, -1.07ms (-0.18d, 0.74p, 5.75std) 1.02x invariant, -0.15ms (-0.92d, 0.11p, 0.17std) 0.99x slower X, 8.09μs (1.77d, 0.01p, 4.58std)
WGLMakie 3.69s (3.66, 3.75) 0.03+- 322.81ms (320.29, 325.98) 2.06+- 8.85s (8.74, 9.03) 0.09+- 9.08ms (8.98, 9.20) 0.09+- 69.33ms (67.83, 73.71) 2.09+-
master 3.68s (3.65, 3.71) 0.02+- 321.71ms (315.50, 326.78) 4.34+- 8.81s (8.71, 8.93) 0.08+- 9.25ms (9.06, 10.20) 0.42+- 72.25ms (68.05, 78.72) 5.07+-
evaluation 1.00x invariant, 0.02s (0.66d, 0.25p, 0.03std) 1.00x invariant, 1.1ms (0.33d, 0.56p, 3.20std) 1.00x invariant, 0.04s (0.46d, 0.41p, 0.08std) 1.02x invariant, -0.16ms (-0.54d, 0.35p, 0.26std) 1.04x invariant, -2.93ms (-0.75d, 0.20p, 3.58std)

@jkrumbiegel jkrumbiegel merged commit 29182dc into master Jan 31, 2024
17 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/fix-textless-brackets branch January 31, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bracket! does not work with vectors when not providing a text argument
2 participants