Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich rticks for PolarAxis #3615

Merged
merged 6 commits into from Feb 21, 2024
Merged

Conversation

jonaswickman
Copy link
Contributor

Description

Fixes issue #3583 (again, this time the rticks)

I based this on the changes made in #3585 to make rich text work for rticks as well as thetaticks. This is my first time trying to make a PR to someone else's repository, so apologies if I made a hash of it.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added unit tests for new algorithms, conversion methods, etc.

Copy link
Member

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will merge in a couple of days if no one else comments and CI passes.

@asinghvi17
Copy link
Member

Needs a reference image update but this PR is otherwise good to go!

@asinghvi17 asinghvi17 added the skip-changelog Skips changelog enforcer label Feb 15, 2024
@ffreyer ffreyer removed the skip-changelog Skips changelog enforcer label Feb 20, 2024
@SimonDanisch SimonDanisch reopened this Feb 21, 2024
@SimonDanisch SimonDanisch merged commit 9068299 into MakieOrg:master Feb 21, 2024
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants