Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RPRMakie with Material #3872

Merged
merged 2 commits into from
May 17, 2024
Merged

fix RPRMakie with Material #3872

merged 2 commits into from
May 17, 2024

Conversation

SimonDanisch
Copy link
Member

No description provided.

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label May 17, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented May 17, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.50s (4.43, 4.57) 0.05+- 105.59ms (104.44, 107.99) 1.26+- 501.39ms (479.97, 545.55) 22.10+- 8.26ms (8.14, 8.41) 0.09+- 25.54ms (25.44, 25.68) 0.08+-
master 4.45s (4.39, 4.51) 0.05+- 105.32ms (104.27, 107.13) 1.15+- 490.35ms (479.52, 525.47) 15.96+- 8.18ms (8.05, 8.27) 0.09+- 25.70ms (25.44, 26.36) 0.31+-
evaluation 0.99x invariant, 0.05s (1.00d, 0.08p, 0.05std) 1.00x invariant, 0.26ms (0.22d, 0.69p, 1.20std) 0.98x invariant, 11.03ms (0.57d, 0.31p, 19.03std) 0.99x invariant, 0.08ms (0.87d, 0.13p, 0.09std) 1.01x invariant, -0.17ms (-0.73d, 0.22p, 0.20std)
CairoMakie 3.75s (3.66, 3.83) 0.07+- 107.60ms (104.13, 112.01) 3.26+- 131.99ms (127.68, 139.15) 4.29+- 7.83ms (7.51, 8.16) 0.19+- 981.43μs (963.90, 992.57) 8.84+-
master 3.68s (3.56, 3.73) 0.06+- 110.95ms (106.07, 114.19) 3.30+- 136.56ms (129.45, 142.29) 5.14+- 7.89ms (7.63, 8.02) 0.16+- 992.86μs (983.76, 999.73) 5.54+-
evaluation 0.98x invariant, 0.07s (1.05d, 0.08p, 0.07std) 1.03x invariant, -3.36ms (-1.02d, 0.08p, 3.28std) 1.03x invariant, -4.56ms (-0.96d, 0.10p, 4.72std) 1.01x invariant, -0.07ms (-0.38d, 0.49p, 0.18std) 1.01x faster ✓, -11.44μs (-1.55d, 0.02p, 7.19std)
WGLMakie 4.72s (4.63, 4.80) 0.06+- 114.98ms (110.88, 120.30) 3.74+- 9.61s (9.39, 9.80) 0.14+- 10.79ms (10.34, 11.54) 0.42+- 74.42ms (70.59, 90.14) 6.99+-
master 4.67s (4.61, 4.71) 0.04+- 111.26ms (107.91, 115.64) 3.14+- 9.48s (9.37, 9.62) 0.11+- 10.71ms (10.41, 10.86) 0.18+- 71.31ms (70.66, 72.15) 0.65+-
evaluation 0.99x invariant, 0.05s (0.99d, 0.09p, 0.05std) 0.97x invariant, 3.72ms (1.08d, 0.07p, 3.44std) 0.99x invariant, 0.14s (1.07d, 0.07p, 0.13std) 0.99x invariant, 0.08ms (0.25d, 0.65p, 0.30std) 0.96x invariant, 3.12ms (0.63d, 0.28p, 3.82std)

@SimonDanisch
Copy link
Member Author

Huh, somehow the GLMakie cat image test became instable and seems to reset to different limits randomly.
Maybe some synchronization issue.
This is unrelated to this PR, will need to investigate this later. @ffreyer maybe you have an idea? I suspect it's related to one of the bb PRs

@SimonDanisch SimonDanisch merged commit dd64632 into master May 17, 2024
17 of 19 checks passed
@SimonDanisch SimonDanisch deleted the sd/rprmakie-fix branch May 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants