Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill frame withzoom (i.e. keep image apect ratio of image fixed) #37

Closed
alex-s-gardner opened this issue Apr 20, 2023 · 3 comments
Closed

Comments

@alex-s-gardner
Copy link
Contributor

When an extent is defined to zoom into the aspect ratio of the displayed image changes. I think this should be changed such that the zoomed image always fills the frame. Otherwise the area of display keeps changing and looks hacky.

@rafaqz
Copy link
Collaborator

rafaqz commented Apr 21, 2023

Should be easy to fix, have a go.

@alex-s-gardner
Copy link
Contributor Author

Looking through the code I can't seem to find where a zoom rectangle triggers a response.

@rafaqz
Copy link
Collaborator

rafaqz commented Apr 21, 2023

Tyler.jl/src/Tyler.jl

Lines 138 to 142 in 346b2c7

on(axis.finallimits) do extent
isopen(screen) || return
update_tiles!(tyler, extent)
return
end

Although note that here the extent is probably a GeometryBasics Rect, but we can convert that to an extent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants