add createXmlSecurityDSig() method #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowing to create it with optional properties
|
What do you think of this implementation ? |
|
XmlDsig is stateful so its not safe reuse the same instance |
|
Ok, so i did as you ask for. Does it fits you ? |
| /** | ||
| * Create the XLMSecurityDSign class | ||
| * | ||
| * @return new XMLSecurityDSig() |
There was a problem hiding this comment.
This does not follow phpdoc syntax. Should be @return XMLSecurityDSig
| * | ||
| * @return new XMLSecurityDSig() | ||
| */ | ||
| protected function createXmlSecurityDSig($options = array()) { |
There was a problem hiding this comment.
The argument $options is not used. Please remove.
Also move the protected method after public methods.
|
Watch this other CS violations https://travis-ci.org/Maks3w/xmldsig/jobs/105999819#L245 |
allowing to create it with optional properties
|
Not used to Travis-ci and php-cs i had some trouble validating the build... But it should be OK now |
|
Looks good. Could you do a last thing? Please squash your commits in a single one |
|
Opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing to create it with optional properties