Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence byte-compiler #150

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Silence byte-compiler #150

merged 1 commit into from
Oct 3, 2022

Conversation

skangas
Copy link
Contributor

@skangas skangas commented Dec 6, 2021

This fixes two byte-compiler warnings.

* aggressive-indent.el (aggressive-indent-mode): Fix byte-compiler
warnings.

@skangas
Silence byte-compiler
d0635da 
* aggressive-indent.el (aggressive-indent-mode): Fix byte-compiler
warnings.
@skangas
Copy link
Contributor Author

skangas commented Dec 28, 2021

BTW, once this is merged, it would be useful to also bump the release so that it is released on GNU ELPA. Thanks!

@dr-scsi dr-scsi mentioned this pull request Aug 17, 2022
Closed
@skangas
Copy link
Contributor Author

skangas commented Oct 3, 2022

@Malabarba friendly ping

@Malabarba Malabarba merged commit 6a96e28 into Malabarba:master Oct 3, 2022
seagle0128
seagle0128 reviewed Oct 4, 2022
View reviewed changes
aggressive-indent.el
@@ -487,7 +487,7 @@ If BODY finishes, `while-no-input' returns whatever value BODY produced."
;;; Minor modes
;;;###autoload
(define-minor-mode aggressive-indent-mode
nil nil " =>"
:lighter " =>"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The docstring was missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #157.

@mplsgrant
Copy link

This change may have created some kind of error for me:

Debugger entered--Lisp error: (wrong-type-argument stringp :lighter)
  string-match("\\bARG\\b" :lighter nil)
  easy-mmode--mode-docstring(:lighter "Aggressive-Indent mode" aggressive-indent-mode-map)

@skangas
Copy link
Contributor Author

skangas commented Oct 5, 2022

This change may have created some kind of error for me:

Debugger entered--Lisp error: (wrong-type-argument stringp :lighter)
  string-match("\\bARG\\b" :lighter nil)
  easy-mmode--mode-docstring(:lighter "Aggressive-Indent mode" aggressive-indent-mode-map)

This should be fixed by #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seagle0128 seagle0128 seagle0128 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skangas @mplsgrant @seagle0128 @Malabarba