Update Node.js from v12 to v16 for Apple M1 support #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesa2
changed the title
According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772
hannesa2
force-pushed
the
Update.Node.js.v16
branch
from
dba9b76
to
298cdbf
Compare
|
@Malinskiy any chance to get this merged to make action work on Apple Silicon M1 ? |
|
Sure thing, but we need to fix https://github.com/Malinskiy/action-android/blob/2e4591be80bdbe897c601bd89046582f28e7d603/prepare-for-release.sh also to use a newer docker image with node 16 Might also need to update the package.json files as well? |
|
Ok, I did prepare-for-release.sh |
hannesa2
force-pushed
the
Update.Node.js.v16
branch
from
8dbaee4
to
2afd9a4
Compare
|
I use now node16 (as good as I can) everywhere |
Malinskiy
approved these changes
Jul 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the release policy of Node.js,
Node.js v12 reached EOL (end-of-life).
https://nodejs.org/en/about/releases/
I think ruby/setup-ruby is ready to update Node.js to v16
because GitHub Actions runners support v16.
actions/runner#772
An I hope this action runs now on a Apple Silicon M1.
close #57