Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump android sdk for mac #80

Open
wants to merge 3 commits into
base: release/0.1.4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: "Test hypervisor support on ubuntu"
on: push
jobs:
test:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: cat /sys/hypervisor/properties/capabilities || true
name: xen
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: "Test Linux"
on: [push, pull_request]
jobs:
test:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v1
- name: test install-sdk
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ jobs:
- name: test install-sdk
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
working-directory: install-sdk
- name: set up JDK
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: 11
- name: test emulator-run-cmd
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
working-directory: emulator-run-cmd
Expand Down
2 changes: 1 addition & 1 deletion emulator-run-cmd/lib/sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class LinuxAndroidSdk extends BaseAndroidSdk {
class MacOSAndroidSdk extends BaseAndroidSdk {
constructor() {
super(...arguments);
this.defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-6858069_latest.zip";
this.defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-9477386_latest.zip";
}
}
class SdkFactory {
Expand Down
2 changes: 1 addition & 1 deletion emulator-run-cmd/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class LinuxAndroidSdk extends BaseAndroidSdk {
}

class MacOSAndroidSdk extends BaseAndroidSdk {
defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-6858069_latest.zip"
defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-9477386_latest.zip"
}

export class SdkFactory {
Expand Down
2 changes: 1 addition & 1 deletion install-sdk/lib/sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class LinuxAndroidSdk extends BaseAndroidSdk {
class MacOSAndroidSdk extends BaseAndroidSdk {
constructor() {
super(...arguments);
this.defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-6858069_latest.zip";
this.defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-9477386_latest.zip";
}
}
class SdkFactory {
Expand Down
2 changes: 1 addition & 1 deletion install-sdk/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class LinuxAndroidSdk extends BaseAndroidSdk {
}

class MacOSAndroidSdk extends BaseAndroidSdk {
defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-6858069_latest.zip"
defaultSdkUrl = "https://dl.google.com/android/repository/commandlinetools-mac-9477386_latest.zip"
}

export class SdkFactory {
Expand Down