Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adam): prevent uncloseable readFully #114

Merged
merged 1 commit into from May 5, 2024
Merged

Conversation

Malinskiy
Copy link
Owner

No description provided.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.18%. Comparing base (d4ea7ee) to head (f69ce1e).

Files Patch % Lines
.../com/malinskiy/adam/transport/vertx/VertxSocket.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
- Coverage     80.20%   80.18%   -0.03%     
  Complexity      707      707              
============================================
  Files           143      143              
  Lines          3193     3194       +1     
  Branches        547      547              
============================================
  Hits           2561     2561              
- Misses          366      367       +1     
  Partials        266      266              
Flag Coverage Δ
integration 63.43% <0.00%> (-0.02%) ⬇️
unit 70.75% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit 6cd8361 into master May 5, 2024
27 of 29 checks passed
@Malinskiy Malinskiy deleted the fix/uncloseable-socket branch May 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant