Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adam): test runner should read only stdout if possible #93

Merged
merged 8 commits into from Feb 1, 2023

Conversation

Malinskiy
Copy link
Owner

@Malinskiy Malinskiy commented Jan 31, 2023

Fixes the issue with the latest Android 31+ and removes the assumption that output of shell requests is UTF-8 encoded

Note: breaking change

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #93 (cbb1d47) into master (27e509b) will decrease coverage by 0.89%.
The diff coverage is 62.99%.

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     81.30%   80.41%   -0.89%     
- Complexity      723      727       +4     
============================================
  Files           142      143       +1     
  Lines          3097     3176      +79     
  Branches        509      542      +33     
============================================
+ Hits           2518     2554      +36     
- Misses          317      358      +41     
- Partials        262      264       +2     
Flag Coverage Δ
integration 63.85% <57.48%> (-0.67%) ⬇️
unit 71.00% <59.84%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inskiy/adam/request/shell/v2/ShellCommandResult.kt 42.10% <35.29%> (-57.90%) ⬇️
...inskiy/adam/request/shell/v1/ShellCommandResult.kt 50.00% <41.66%> (-50.00%) ⬇️
...m/request/shell/v2/ChanneledShellCommandRequest.kt 59.72% <43.13%> (-40.28%) ⬇️
...am/request/shell/AsyncCompatShellCommandRequest.kt 100.00% <100.00%> (ø)
...request/shell/v1/ShellResultResponseTransformer.kt 100.00% <100.00%> (ø)
...y/adam/request/shell/v2/SyncShellCommandRequest.kt 96.00% <100.00%> (ø)
...nskiy/adam/request/testrunner/TestRunnerRequest.kt 93.61% <100.00%> (+3.23%) ⬆️
...m/request/shell/v1/ChanneledShellCommandRequest.kt 85.71% <0.00%> (+7.14%) ⬆️
.../adam/request/device/FetchDeviceFeaturesRequest.kt 100.00% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant