chore: Update vite config of build cjs output

[rxliuli]

ref: microsoft/vscode#130367 (comment)

before:

after:

[Malix-off]

Holy fuck @rxliuli thanks a lot!
Also, shouldn't I specify something in the https://github.com/Malix-off/VSC-Extension-StashFlow/blob/dev/tsconfig.json too?
I noticed the "moduleResolution": "bundler" option constraints me to use "module": "es2015" // or later

[rxliuli]

Holy fuck @rxliuli thanks a lot! Also, shouldn't I specify something in the https://github.com/Malix-off/VSC-Extension-StashFlow/blob/dev/tsconfig.json too? I noticed the "moduleResolution": "bundler" option constraints me to use "module": "es2015" // or later

tsconfig.json only affects the development phase, specifically vscode code prompts, the build is completely taken over by vite, and ts compilation uses esbuild instead of tsc.

[Malix-off]

@rxliuli

tsconfig.json only affects the development phase, specifically vscode code prompts, the build is completely taken over by vite, and ts compilation uses esbuild instead of tsc.

Oh okay, thanks for that clarification!
It would have been very much easier if vite could infer those parameters through tsconfig rather than having two different boilerplate 😄

Do you know if it would be better to keep my https://github.com/Malix-off/VSC-Extension-StashFlow/blob/dev/tsconfig.json with "module": "ESNext" to make it compliant with "moduleResolution": "bundler", or should I edit it to make "module": "CommonJS" and change "moduleResolution": "bundler" to something else?

[rxliuli]

Just a personal opinion, "module": "ESNext" is always best as writing code always expects esm not cjs.

[Malix-off]

@rxliuli

Just a personal opinion, "module": "ESNext" is always best as writing code always expects esm not cjs.

Okay, thanks for your insights and your help, I really do appreciate ❤️