-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle + Standard project structure #20
Conversation
d105dae
to
653ca8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I saw a todo, asking for which is the current version. It is 1.2.1 For JNA: It's JNA-platform |
It doesn't find the icon which was in "/resources/tray_icon.png". you probably moved it. Set the correct path at line 18 of Tray.java |
I can't understand the error at the moment, I will look further into this tomorrow |
In that case, please check the PR. Check the left TODOs in the description, and think if you desire to change those. When checking the PR, each commit can be read chronologically, so that you see what I changed and why. If you think my PR is good enough, feel free to merge. If something doesn't make sense, please ask. |
Ok, the issue was caused by gradle not building the Intellij Swing desgner that I used to design the UI. I changed a setting in Intellij to make it work: https://stackoverflow.com/a/55725767/9419492 read the comments if your Intellij is > 2019.1 |
content no longer needed
Ok now the only thing left is the |
I have never used Install4j, however since it's not part of the source code, nor is it a resource needed during application run, it can stay in project root folder as it is now. |
I suggest you go and 👍 this issue and the 2 related ones, so that Jetbrains sees if people are affected by it: https://youtrack.jetbrains.com/issue/IDEA-223518 It seems to be mentioned in the docs as well, the green box at the top: https://www.jetbrains.com/help/idea/gui-designer.html. This is unfortunate (maybe?) because with gradle you could have created the jar for the project simply by running |
Ok, added the 👍 to the issue. I did find this plugin that should've handled the thing automatically https://github.com/File5/intellij-idea-guidesigner-plugin, but probably due to my inexperience I couldn't make it work |
You can add the plugin and push and i will check it out. That's the best way to learn how to use gradle. |
though, it still doesn't work without enabling the right option in settings
Tried to add the plugin as described by the github page, but still it doesn't work if I don't enable the right setting in the settings. I even tried some variations, but no way to make it work, it always give some error about a missing class (I think it's a class needed for the UI builder). |
Yep, i cant figure it out either, sorry. Just revert then merge. |
This reverts commit c0921f0.
Thanks for all the help! |
This PR adds gradle support for dependencies, and also updates the code to a structured layout.
Left to to (if desired by @Mamiglia ):
com.mamiglia
.build
folder (to where?)Installer
folder (to where?)Fixes: #19