Enable support for TextView expand/collapse toggle and custom Ids #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 8, 2016 16:48
… expand / collapse toggle. Currently ImageButton and TextView are supported, default is ImageButton.
This will correct issues such as when a longer text was expanded and then a shorter one get set on the view, the layout stayed the same height. This resulted in much unused space.
|
This would be awesome. Amazon for example use "Read more" text to expand a customer review to full size |
|
I think that this is great addition to the original lib. It would be so much better if you could've add some docs to the readme file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to choose the expand/collapse toggle view, currently ImageButton and TextView are supported, ImageButton is the default.
Added support for custom Ids of the expandable TextView and expand/collapse toggle View.