Skip to content
This repository has been archived by the owner on Dec 12, 2019. It is now read-only.

Make port and SSL optional #43

Merged
merged 2 commits into from
May 23, 2014
Merged

Conversation

xtagon
Copy link
Contributor

@xtagon xtagon commented May 23, 2014

Also sets use_ssl and port based on URI scheme if they're not already set.

Tests still pass, but I haven't added any new ones.

Resolves #42

The default proxy host/port options don't need to be explicitly set anymore, since they default to nil in the options hash now.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3038f91 on xtagon:feature/ssl-optional into 7b5930c on ManageIQ:master.

@Fryguy
Copy link
Member

Fryguy commented May 23, 2014

Looks good! Should https? be a private method? Aside from that, fix up the rubocop comments, and this looks good to merge. Thanks!

@xtagon
Copy link
Contributor Author

xtagon commented May 23, 2014

@Fryguy https? could be made private if you want, but I figured it would be useful to be able to check whether my service objects are using HTTPS or HTTP. I fixed the rubocop stuff.

@Fryguy
Copy link
Member

Fryguy commented May 23, 2014

👍

Fryguy added a commit that referenced this pull request May 23, 2014
@Fryguy Fryguy merged commit 0394f5a into ManageIQ:master May 23, 2014
@cfme-bot
Copy link
Member

Checked commits xtagon@3038f91 .. xtagon@56d72df with rubocop 0.21.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@xtagon xtagon deleted the feature/ssl-optional branch May 23, 2014 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSL Certificate Error
4 participants