Added Configuration#validate_subscription! #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
force-pushed
the
validate_subscription
branch
from
fb02d42
to
8089992
Compare
|
@bzwei First attempt. What do you think? |
|
@djberg96 since configuration constructor already validate tenant ID, client ID/key, why don't we include validation of subscription ID there without making it an explicitly call for user? |
|
@bzwei I'm ok with an up-front validation, but it does mean an extra http request they wouldn't otherwise need to make. |
|
I am voting for this solution because it makes the validation behaviors the same for all user provided IDs. |
djberg96
force-pushed
the
validate_subscription
branch
2 times, most recently
from
9920f0b
to
b09ddae
Compare
djberg96
force-pushed
the
validate_subscription
branch
from
b09ddae
to
bceda57
Compare
|
@bzwei I updated the code to validate the subscription in the constructor and updated the specs. |
djberg96
force-pushed
the
validate_subscription
branch
from
bceda57
to
492d161
Compare
Automatically perform subscription_id validation in the constructor instead of making it a separate, optional method. Update spec_helper.rb to stub validate_subscription, and update subscription_id test.
djberg96
force-pushed
the
validate_subscription
branch
from
492d161
to
9af45f1
Compare
|
Checked commit djberg96@9af45f1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 lib/azure/armrest/configuration.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Configuration#validate_subscription! method, and addresses #189.
The main issue is that the constructor effectively does a validation check for tenant ID, client ID and client key via the
fetch_providersmethod, but it does not validate the subscription. This method allows users to explicitly validate the subscription and/or check to ensure that it's enabled.