Add get_by_id and get_subservice_by_id

[djberg96]

This adds two methods to the ResourceGroupBasedService that will allow users to get objects based on an ID string without having to parse that information out themselves.

For example, a VM contains an ID for its NIC like this:

"id": "/subscriptions/xyz/resourceGroups/some_group/providers/Microsoft.Network/networkInterfaces/some_nic"

With that information we can then get a model object like so:

nic_id = vm.properties.network_profile.network_interfaces[0].id
vms.get_by_id(nic_id)

This will also make deleting associated resources easier.

[djberg96]

@bzwei @bronaghs Please review.

[bzwei]

suggest method name get_associate_resource

[djberg96]

Hm, ok, but I've kept the originals as aliases because I like short method names. :)

[bzwei]

let's follow the indent style required by rubocop

[djberg96]

I think the indent style that rubocop wants is terrible.

[djberg96]

@bzwei Ok, I modified the code so that it's a single method that works with either a service or subservice.

[bzwei]

We can simply maintain a hash table for the lookup instead of long list of case/when

[djberg96]

@bzwei ok, done.

[bzwei]

@djberg96 looks good. Can you address the warnings from rubocop?

[miq-bot]

Checked commits djberg96/azure-armrest@a413205~...d7255ab with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 1 offense detected

lib/azure/armrest/resource_group_based_service.rb

• ❕ - Line 102, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for get_associated_resource is too high. [30.15/20]

[djberg96]

@bzwei ok, fixed the rubocop warnings that I could.

[bronaghs]

👍