Change get_template to return a string #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Mar 23, 2017
| # | ||
| def get_template(deploy_name, resource_group = configuration.resource_group) | ||
| validate_resource_group(resource_group) | ||
| validate_resource(deploy_name) | ||
| url = build_url(resource_group, deploy_name, 'exportTemplate') | ||
| response = JSON.parse(rest_post(url))['template'] | ||
| DeploymentTemplate.new(response) | ||
| JSON.parse(rest_post(url))['template'].to_json |
There was a problem hiding this comment.
We should remove DeploymentTemplate from base_model.rb.
There was a problem hiding this comment.
@bzwei I thought about it, but thought it might be nice for people who do want to convert it. Or do you think that will just lead to confusion?
Remove DeploymentTemplate model.
|
@bzwei Ok, removed that model. |
|
Checked commit djberg96@5f1735a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bzwei
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TemplateDeploymentService#get_templatemethod currently tries to generate and return aDeploymentTemplatemodel object. However, this is problematic because a template can contain arbitrary text that our base model cannot translate into a real Ruby constant.Consequently, this method has been altered to just return a plain JSON string instead of a model object. While this technically breaks backwards compatibility, the reality is that this method is likely unused in the wild since it's just a matter of time before it fails, and that the raw JSON is what people are after anyway. ~~~That said, I have left the
DeploymentTemplatemodel in the code for those people who may want to try and convert it to an object on their own.~~~Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1434988