fixed #70: provider name is now case insensitive #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus some minor refactoring
bzwei
force-pushed
the
case_insensitive
branch
from
83d2147
to
7880a6d
Compare
|
Looks good to me. I think eventually we'll want to leverage the Resource, ResourceGroup and ResourceProvider service classes. |
djberg96
added a commit
that referenced
this pull request
Sep 17, 2015
fixed #70: provider name is now case insensitive
This was referenced Sep 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the key in the hash is lower case.
Plus some minor refactoring.
Rename
@@providersto@@providers_hashto avoid some naming confusion because the class has antherprovidersmethod.