Switch to GitHub Actions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
github_actions
branch
3 times, most recently
from
9dd5680
to
425f1d8
Compare
|
I want to change this one to not hardcode the full 3-digit version number but I can't because of ruby/setup-ruby#304 |
The latest rack, which was used as the "gem with no dependencies", introduced a new dependency, complicating the specs, so this commit replaces them with gems that following the same pattern, but haven't been updated in a long time. - rack-obama is replaced with rubytest - rack is replaced with ansi The gem versions used in these specs follow a specific pattern in order to test various versions and overrides. rubytest 0.7.0 depends on ansi >= 0 which has no dependencies. This allows us to manipulate the various versions of ansi without introducing additional dependencies complicating the test. ansi 1.4.2, 1.4.3, 1.5.0 are the three latest versions, and most tests "start" with ansi 1.4.3 in the base Gemfile. omg 0.0.6 is an additional gem that also has no dependencies.
|
@agrare This is ready to go. It's easier to review commit by commit because I had to completely choose new gems to test against. |
agrare
approved these changes
Apr 5, 2022
agrare
added a commit
that referenced
this pull request
Jan 9, 2024
Fixed * Remove remnants of bundler 1.x support (#20) * Fix detection of bundler version (#21) * Fix spec issues after release of bundler 2.4.17 (#32) Added * Switch to GitHub Actions (#25) * Add bundler 2.4 to the test matrix (#28) * Add Ruby 3.1 and 3.2 to test matrix (#29) * Allow user to specify a PATH to search for gem overrides (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://github.com/Fryguy/bundler-inject/actions?query=branch%3Agithub_actions
Easier to review in 2 commits
The second commit changes all of the tests gems: