Move the guts of the CLI into a class for easier testing #220
+233
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
commented
Jun 18, 2024
| # Create workflow/input pairs from the various combinations of paramaters | ||
| workflows_inputs = | ||
| if opts[:workflow_given] | ||
| Optimist.die("cannot specify both --workflow and bare workflows") if args.any? |
There was a problem hiding this comment.
Now that this is in a class, these Optimist.die statements actually raise a SystemExit, which means this is kind of gross. I started refactoring to use an Optimist::Parser, but then this code started getting too complicated, so I left the PR as is to be a more pure moving of the code. We can follow up with better cleanup later if needed (or not - it's a CLI class after all).
Fryguy
force-pushed
the
cli_to_class
branch
2 times, most recently
from
4da92c9
to
629e6e0
Compare
|
Some comments on commit Fryguy@49daace lib/floe/cli.rb
|
|
Checked commit Fryguy@49daace with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept a singular test in there that ensures we are calling the exe/floe interface properly, but I'm really not sure if we need it or not. I'd be ok with dropping it. It would save an additional 0.13s knocking the time down to 0.85s or so
@kbrock Please review.
Fixes #218