Rubocop disable AccessModifierDeclarations?

[Fryguy]

See https://rubydoc.info/gems/rubocop/0.69.0/RuboCop/Cop/Style/AccessModifierDeclarations

tl;dr

# group (default)
class Foo
  def method0
  end

  private

  def method1
  end

  def method2
  end
end

# inline
class Foo
  def method0
  end

  private def method1
  end

  private def method2
  end
end

I would like to disable this cop. I like inline modifiers, but this new cop is enforcing the group style. I don't think we have a preference collectively, so I'd like to disable it and allow for inline in addition to group.

Please vote with what you think.

👍 - allow developers to do both group and inline (disable the cop)
👎 - only support group, do not allow inline (leave it as is)
🚀 - only support inline, do not allow group (opposite than currently)

[NickLaMuro]

@Fryguy This will make it more complicated, but this is also an option for individual declaration that I prefer over inline declaration:

class Foo
  def method0
  end
  private :method0
end

Not sure if this is something that is affected by this rule.

[Fryguy]

That style is part of group

[NickLaMuro]

That style is part of group

Oh, then in that case, I guess I am going to be "that guy"... sorry

¯\_(ツ)_/¯

[Fryguy]

Oh I'm sorry...I'm completely wrong...that is part of inline

class Blah
  def foo

  end
  private :foo
end

blah.rb:5:3: C: Style/AccessModifierDeclarations: private should not be inlined in method definitions.
  private :foo
  ^^^^^^^

[NickLaMuro]

Geez... now you make me look bad... thanks.... so offended...

And now I look like I am just one of the 🐑 ...

[ghost]

And finally, what's the decision ?

[Fryguy]

Looks like disable is the choice...I'll send up a PR for that.