Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Commit

Permalink
[1LP][RFR] Fixed KeyError and AssertionError in inline automate method (
Browse files Browse the repository at this point in the history
#8239)

* Fixed KeyError and AssertionError
 - Fixed Keyerror: while getting vSphere provider's small_template.
 - keyError was the reason; this test was getting skipped.
 - Fixed assertionError; while assrting flash message of data validation.

* updated with requested changes
  • Loading branch information
Ganesh Hubale authored and mshriver committed Dec 6, 2018
1 parent 407fe2d commit 2a2a490
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions cfme/automate/explorer/method.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ def create(
add_page = navigate_to(self, 'Add')
add_page.fill({'location': location})
if location == 'inline':
add_page.wait_displayed()
add_page.fill({
'inline_name': name,
'inline_display_name': display_name,
Expand All @@ -471,6 +472,7 @@ def create(
validate = False
if validate and not BZ(1499881, forced_streams=['5.9']).blocks:
add_page.validate_button.click()
add_page.wait_displayed()
add_page.flash.assert_no_error()
add_page.flash.assert_message('Data validated successfully')
if cancel:
Expand Down
2 changes: 1 addition & 1 deletion cfme/tests/automate/test_vmware_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def testing_group(appliance, request):
def testing_vm(setup_provider, provider):
collection = provider.appliance.provider_based_collection(provider)
try:
template_name = provider.data['full_template']['name']
template_name = provider.data['templates']['full_template']['name']
except KeyError:
pytest.skip('Unable to identify full_template for provider: {}'.format(provider))

Expand Down

0 comments on commit 2a2a490

Please sign in to comment.