-
Notifications
You must be signed in to change notification settings - Fork 164
Conversation
6d74d2e
to
35d7375
Compare
fixed fixture scope typo Added InfraVm compare view and toolbar view adding compare genealogy view fix typo
35d7375
to
eff3342
Compare
I detected some fixture changes in commit eff3342 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes, looking good @spusateri!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your work on this @spusateri
try: | ||
compare_view = create_vm_with_clone[0].genealogy.compare(*create_vm_with_clone) | ||
assert compare_view.is_displayed | ||
except ToolbarOptionGreyedOrUnavailable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
"""Fixture to provision a VM and clone it""" | ||
first_name = fauxfactory.gen_alphanumeric() | ||
last_name = fauxfactory.gen_alphanumeric() | ||
email = "{first_name}.{last_name}@test.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to use f-sting
here. Other thought fauxfactory.gen_email()
PRT Run
{{ pytest: cfme/tests/cloud_infra_common/test_genealogy.py -k "test_genealogy_comparison" --use-provider vsphere65-nested }}