This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automating dynamic refresh dialog test #10052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
changed the title
niyazRedhat
force-pushed
the
dyn_dialog
branch
2 times, most recently
from
318b724
to
f5e6764
Compare
niyazRedhat
force-pushed
the
dyn_dialog
branch
3 times, most recently
from
69cb46e
to
1df36e1
Compare
john-dupuy
added
the
test-automation
valaparthvi
reviewed
Apr 22, 2020
Comment on lines
499
to
509
| menu = view.fields("menu").read() | ||
| topping = view.fields("dropdown_list_1").read() | ||
|
|
||
| if menu == 'Burger': | ||
| assert topping == 'Black Bean' | ||
| elif menu == "Fries": | ||
| assert topping == "Sweet Potato" | ||
| elif menu == 'Shake': | ||
| assert topping == 'Vanilla' | ||
| elif menu == 'Empty Set': | ||
| assert topping == 'Nothing selected for parent dialog' |
There was a problem hiding this comment.
How is the value selected for menu? Is it random or does it stay the same always?
There was a problem hiding this comment.
@valaparthvi It randomly select the value when we refresh the field view.fields("Menu").refresh.click()
There was a problem hiding this comment.
Optional
Suggested change
| menu = view.fields("menu").read() | |
| topping = view.fields("dropdown_list_1").read() | |
| if menu == 'Burger': | |
| assert topping == 'Black Bean' | |
| elif menu == "Fries": | |
| assert topping == "Sweet Potato" | |
| elif menu == 'Shake': | |
| assert topping == 'Vanilla' | |
| elif menu == 'Empty Set': | |
| assert topping == 'Nothing selected for parent dialog' | |
| data = {"Burger": "Black Bean", "Fries": "Sweet Potato", "Shake": "Vanilla", "Empty Set": "Nothing selected for parent dialog"} | |
| assert topping == data[menu] |
valaparthvi
added
the
test-cleanup
valaparthvi
approved these changes
Apr 22, 2020
Comment on lines
499
to
509
| menu = view.fields("menu").read() | ||
| topping = view.fields("dropdown_list_1").read() | ||
|
|
||
| if menu == 'Burger': | ||
| assert topping == 'Black Bean' | ||
| elif menu == "Fries": | ||
| assert topping == "Sweet Potato" | ||
| elif menu == 'Shake': | ||
| assert topping == 'Vanilla' | ||
| elif menu == 'Empty Set': | ||
| assert topping == 'Nothing selected for parent dialog' |
There was a problem hiding this comment.
Optional
Suggested change
| menu = view.fields("menu").read() | |
| topping = view.fields("dropdown_list_1").read() | |
| if menu == 'Burger': | |
| assert topping == 'Black Bean' | |
| elif menu == "Fries": | |
| assert topping == "Sweet Potato" | |
| elif menu == 'Shake': | |
| assert topping == 'Vanilla' | |
| elif menu == 'Empty Set': | |
| assert topping == 'Nothing selected for parent dialog' | |
| data = {"Burger": "Black Bean", "Fries": "Sweet Potato", "Shake": "Vanilla", "Empty Set": "Nothing selected for parent dialog"} | |
| assert topping == data[menu] |
valaparthvi
changed the title
mshriver
approved these changes
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dynamicdd_dialogelement.py::test_dynamic_field_update_on_refresh -vvvv --long-running }}
test_regex_validation_should_workthis is also covered in this PRtest_reconfigure_service_for_dialogs_with_timeout_values, we already have automation ->test_reconfigure_servicetest_should_be_able_to_see_requests_if_our_users..., we already have related testtest_service_rbac_request