This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automated test_storage_volume_backup_restore tests #10057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmojzis
changed the title
john-dupuy
approved these changes
Apr 22, 2020
john-dupuy
added
the
test-automation
john-dupuy
reviewed
Apr 22, 2020
Comment on lines
+132
to
+133
| wait_for(lambda: restored_volume.status == 'available', fail_func=backup.refresh, delay=30, | ||
| timeout=600) |
There was a problem hiding this comment.
In order for this test to assert properly I think this should be like,
try:
wait_for(lambda: restored_volume.status == 'available', fail_func=backup.refresh, delay=30,
timeout=600)
except TimedOutError:
pytest.fail("Failed waiting for volume to become available")But I'd consider it optional for now.
john-dupuy
changed the title
mshriver
approved these changes
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.