Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix typo in skip_msg format when provider setup fails. #10068

Merged
merged 1 commit into from
Apr 22, 2020
Merged

[1LP][RFR] Fix typo in skip_msg format when provider setup fails. #10068

merged 1 commit into from
Apr 22, 2020

Conversation

tpapaioa
Copy link
Contributor

This PR makes a small fix to the construction of the skip_msg string passed to pytest.skip() when the setup_provider fixture fails to set up the provider. The skip_msg variable was accidentally set to be a tuple instead of a string, resulting in a TypeError:

E       TypeError: Skipped expected string as 'msg' parameter, got 'tuple' instead.
E       Perhaps you meant to use a mark?

cfme/fixtures/provider.py:87: TypeError
TypeError
b"Skipped expected string as 'msg' parameter, got 'tuple' instead.\nPerhaps you meant to use a mark?"

@dajoRH dajoRH added the lint-ok label Apr 20, 2020
cfme/fixtures/provider.py Outdated Show resolved Hide resolved
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tpapaioa!

@john-dupuy john-dupuy changed the title [RFR] Fix typo in skip_msg format when provider setup fails. [1LP][RFR] Fix typo in skip_msg format when provider setup fails. Apr 21, 2020
@mshriver mshriver self-assigned this Apr 22, 2020
@mshriver mshriver merged commit 5858171 into ManageIQ:master Apr 22, 2020
@tpapaioa tpapaioa deleted the fix_provider_fixture_skip branch April 22, 2020 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants