Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] added blocker marker #10091

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented May 5, 2020

Purpose or Intent

PRT Run

{{pytest: ./cfme/tests/control/test_actions.py -k "test_action_stop_virtual_machine_after_starting or test_action_suspend_virtual_machine_after_starting" --long-running -v}}

@dajoRH
Copy link
Contributor

dajoRH commented May 8, 2020

I detected some fixture changes in commit a17131aa43b31b8a5fc6ede7b995de1da783f582

The local fixture vm_off is used in the following files:

  • cfme/tests/control/test_actions.py
    • test_action_stop_virtual_machine_after_starting
    • test_action_suspend_virtual_machine_after_starting
    • test_action_prevent_event
    • test_action_power_on_logged
    • test_action_power_on_audit
    • test_action_tag
    • test_action_untag

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dgaikwad dgaikwad changed the title [WIPTEST] Fixed - Timeout issue [WIPTEST] added blocker marker May 11, 2020
@dgaikwad dgaikwad changed the title [WIPTEST] added blocker marker [RFR] added blocker marker May 11, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@john-dupuy john-dupuy changed the title [RFR] added blocker marker [1LP][RFR] added blocker marker May 11, 2020
@mshriver mshriver self-assigned this May 14, 2020
@mshriver mshriver added the blockers-only To be applied on PRs which contain blocker modifications ONLY label May 14, 2020
@mshriver mshriver merged commit ac9a2f5 into ManageIQ:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blockers-only To be applied on PRs which contain blocker modifications ONLY lint-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants