This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] - Removing duplicate test #10106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaikwad
changed the title
valaparthvi
reviewed
May 11, 2020
Comment on lines
2818
to
2822
| user, _ = user_self_service_role | ||
|
|
||
| with user: | ||
| with appliance.context.use(ViaSSUI): | ||
| appliance.server.login(user) |
There was a problem hiding this comment.
It kinda looks like a smoke test. If you think so too, better to add a smoke test marker.
valaparthvi
added
the
test-automation
|
We already have automation covered for this senario |
|
@dgaikwad This could be easily parametrized and combined with #10105, but as @niyazRedhat if we already have coverage for this scenario we should just remove this test case. @niyazRedhat can you provide a link? |
|
@niyazRedhat Thanks for your suggestion. @john-dupuy found this test which is doing same: |
dgaikwad
force-pushed
the
test_self_service_users_ssui
branch
from
6f03d35
to
826ad3e
Compare
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_self_service_users_ssui
branch
from
826ad3e
to
72cb93a
Compare
dgaikwad
force-pushed
the
test_self_service_users_ssui
branch
from
72cb93a
to
9a6641b
Compare
dgaikwad
changed the title
john-dupuy
approved these changes
May 13, 2020
valaparthvi
approved these changes
May 14, 2020
valaparthvi
changed the title
valaparthvi
added
test-cleanup
mshriver
approved these changes
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate test case
Purpose or Intent
PRT Run