This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix the test for OSP #10115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
force-pushed
the
fix_test_single_vm_migration_power_state_tags_retirement
branch
3 times, most recently
from
7736e3b
to
249ccf0
Compare
valaparthvi
reviewed
May 20, 2020
| migrated_vm = rhv_prov.mgmt.get_vm(src_vm.name) | ||
| assert power_state in migrated_vm.state | ||
| migrated_vm = get_migrated_vm(src_vm, provider) | ||
| vm_state = migrated_vm.state if provider.one_of(RHEVMProvider) else migrated_vm.mgmt.state |
There was a problem hiding this comment.
Can't you just take migrated_vm.mgmt.state for both the providers? It should give you the same value.
| assert power_state in migrated_vm.state | ||
| migrated_vm = get_migrated_vm(src_vm, provider) | ||
| vm_state = migrated_vm.state if provider.one_of(RHEVMProvider) else migrated_vm.mgmt.state | ||
| assert power_state in vm_state |
There was a problem hiding this comment.
Shouldn't this be assert power_state == vm_state?
There was a problem hiding this comment.
It wont return the exact string, the out put is like "'VmState.RUNNING'"
Signed-off-by: mnadeem92 <mnadeem@redhat.com>
mnadeem92
force-pushed
the
fix_test_single_vm_migration_power_state_tags_retirement
branch
from
249ccf0
to
d538f07
Compare
valaparthvi
approved these changes
May 21, 2020
valaparthvi
changed the title
mshriver
approved these changes
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 mnadeem@redhat.com
{{ pytest: cfme/tests/v2v/test_v2v_migrations_single_vcenter.py -k "test_single_vm_migration_power_state_tags_retirement" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 }}