Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fixing TC v2v_custom_attribute #10136

Merged
merged 1 commit into from
May 26, 2020

Conversation

mnadeem92
Copy link
Contributor

Signed-off-by: mnadeem92 mnadeem@redhat.com

The Test case was failing as the resources flavor and security group are not available to the cluster.

The Test case is to test the custom attribute flavor and security group by providing a new value for these params other than the default one.
security-group:
default --> provider.data.security_groups.admin[0]
custom value --> provider.data.security_groups.admin[1]
flavor
default --> provider.data.flavors[0]
custom value --> provider.data.flavors[1]

As per TC requirement, we are not required to change the cluster, however in TC cluster gets changed from "admin" to "on-qa" , However the above security-group and flavor is a part of "admin" project and not available in on-qa cluster, This was the main reason for TC failure.

This PR fixing this issue.

{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k "test_v2v_custom_attribute" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 -v }}

Signed-off-by: mnadeem92 <mnadeem@redhat.com>
@mnadeem92 mnadeem92 force-pushed the fix_test_v2v_custom_attribute branch from e4c2803 to 224fbd1 Compare May 22, 2020 17:21
@mnadeem92 mnadeem92 changed the title [WIPTEST] Fixing TC v2v_custom_attribute [RFR] Fixing TC v2v_custom_attribute May 22, 2020
@jarovo
Copy link
Contributor

jarovo commented May 22, 2020

It took me a good while, but I think I am beginning to grasp what is going on here. The code used to change more than one field. It happens that change to field, that is not relevant to the test, makes some values in other field, that is relevant, invalid and that breaks the test. The fix here is to change only one relevant field.

In total, you are removing bunch of lines and I believe making broken test passing, hopefully still validly. thumbs up

@jarovo jarovo changed the title [RFR] Fixing TC v2v_custom_attribute [1LP][RFR] Fixing TC v2v_custom_attribute May 22, 2020
@digitronik digitronik merged commit e08fa48 into ManageIQ:master May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants