This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] Fix log collection tests. #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2020 15:47
The getattr seems unecessary as when the all_ips is not present in the object, it probably never will be. Better to fail fast in that case. Also add typing to make more clear what is the expected input.
added 2 commits
June 26, 2020 15:58
Also, remove unused function.
|
I detected some fixture changes in commit 513a35b The global fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
jarovo
changed the title
mshriver
approved these changes
Jul 1, 2020
jawatts
approved these changes
Jul 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incident in our lab preventing the tests to pass as they cannot connect ssh. This happens only with certain sprout vm provider. This was worked-around.
Test appeared to be wrongly trying to match appliance.server.sid as a zone id. I believe this is not correct. I made the tests passing by using the server's zone every time.
{{ py.test: -sv 'cfme/tests/configure/test_log_depot_operation.py::test_collect_multiple_servers' -v --use-provider 'complete' --long-running cfme/utils/tests/test_connect_ssh.py cfme/tests/configure/test_proxy.py cfme/tests/cli/test_appliance_console_db_restore.py cfme/tests/infrastructure/test_snapshot.py::test_verify_revert_snapshot }}
There is one test failed with
[Errno 104] Connection reset by peerwhich is the same failure I have seen before. Not related