Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Improve email tests. #10177

Merged
merged 7 commits into from
Jul 2, 2020
Merged

[1LP][RFR] Improve email tests. #10177

merged 7 commits into from
Jul 2, 2020

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Jun 8, 2020

Purpose or Intent

For checking CC and Bcc we need improvement of mock SMTP server we have.

Tests ran on with my jenkins job due to problems with connection to the PRT container:
https://cfmeqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/downstream-511-tests-jhenner/19/

In above, the virtualcenter provision_approval tests had problems to pass. They seem to be flaky as seen here:
https://cfmeqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/downstream-511-tests-jhenner/19/testReport/cfme.tests.cloud_infra_common/test_provisioning/
The failure seem not related:

>       wait_for(lambda: self.server_roles == roles, num_sec=timeout, delay=15)
E       wait_for.TimedOutError: Could not do 'lambda defined as `wait_for(lambda: self.server_roles == roles, num_sec=timeout, delay=15)`' at /var/ci/workspace/downstream-511-tests-jhenner/integration_tests/cfme/utils/appliance/__init__.py:1935 in time

Locally passed: cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-edit] PASSED

{{py.test: -sv cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval cfme/tests/configure/test_email.py::test_send_test_email --use-provider complete }}

@jarovo jarovo linked an issue Jun 8, 2020 that may be closed by this pull request
@jarovo jarovo changed the title Improve SMTP collector. [WIPTEST] Improve SMTP collector. Jun 9, 2020
@jarovo jarovo changed the title [WIPTEST] Improve SMTP collector. [WIPTEST] Improve email tests. Jun 30, 2020
@jarovo jarovo changed the title [WIPTEST] Improve email tests. [RFR Improve email tests. Jul 1, 2020
@jarovo jarovo changed the title [RFR Improve email tests. [RFR] Improve email tests. Jul 1, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jul 2, 2020

I detected some fixture changes in commit 5278d32

The local fixture email_addresses_configuration is used in the following files:

  • cfme/tests/cloud_infra_common/test_provisioning.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@mshriver mshriver changed the title [RFR] Improve email tests. [1LP][RFR] Improve email tests. Jul 2, 2020
@mshriver mshriver merged commit 2e7a4cc into ManageIQ:master Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smtp_test fixture should consider mails sent to cc and bcc
3 participants