This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] New test: test_create_from_template #10221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
changed the title
ganeshhubale
changed the title
mshriver
reviewed
Jun 29, 2020
| @@ -710,8 +710,11 @@ def validate_stats(self, ui=False): | |||
| return | |||
| else: | |||
| # Set off a Refresh Relationships | |||
| method = 'ui' if ui else None | |||
| self.refresh_provider_relationships(method=method) | |||
| if self.category == "config_manager" and ui: | |||
There was a problem hiding this comment.
Why go the route of making checks and changing function calls based on the category, instead of updating ConfigManager base class to be consistent with the BaseProvider methods?
There was a problem hiding this comment.
Talked with Parthvi about this, due to the level of effort in updating BaseProvider/ConfigManager base class, I'm going to prioritize the test coverage over rejecting these customization within BaseProvider.
valaparthvi
changed the title
valaparthvi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Fixing
BaseProvider.setup()work for Config Managers.Adding tests
test_create_from_templatePRT Run
{{ pytest: cfme/tests/services/test_rest_services.py -k test_create_from_template --use-provider=complete -svvv }}