Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] New test: custom_attributes subcollection for hosts #10222

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

valaparthvi
Copy link
Contributor

Purpose or Intent

  • Updating tests
    1. TestCustomAttributesRESTAPI to also test for hosts and setting provider selector to ONE, there is no need to test for every provider.

PRT Run

{{ pytest: cfme/tests/cloud_infra_common/test_custom_attributes_rest.py -k hosts -svvv --long-running }}

@dajoRH
Copy link
Contributor

dajoRH commented Jun 27, 2020

I detected some fixture changes in commit 9895fdf

The local fixture get_host is used in the following files:

  • cfme/tests/cloud_infra_common/test_custom_attributes_rest.py
    • get_resource

The local fixture get_resource is used in the following files:

  • cfme/tests/cloud_infra_common/test_custom_attributes_rest.py
    • test_add
    • test_delete_from_detail_post
    • test_delete_from_detail_delete
    • test_delete_from_collection
    • test_delete_single_from_collection
    • test_edit
    • test_bad_section_edit
    • test_bad_section_add
    • test_add_duplicate

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [WIPTEST] New test: custom_attributes subcollection for hosts [RFR] New test: custom_attributes subcollection for hosts Jun 28, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] New test: custom_attributes subcollection for hosts [1LP][RFR] New test: custom_attributes subcollection for hosts Jun 29, 2020
@mshriver mshriver merged commit 548efbe into ManageIQ:master Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants