This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] fixing the test_migration_restart TC #10247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
force-pushed
the
fixing_test_migration_restart
branch
from
892f7dc
to
55c07c9
Compare
mnadeem92
changed the title
valaparthvi
reviewed
Jul 10, 2020
| # reboot system when the actual disk migration elapsed a 240 second time duration | ||
| migration_plan.in_progress(plan_elapsed_time=240) | ||
| appliance.restart_evm_rude() | ||
| return True |
There was a problem hiding this comment.
Wouldn't you need to return False in any condition?
There was a problem hiding this comment.
No, we do not require any True and False condition here even the wait_for is also not required, I have updated it.
Signed-off-by: mnadeem92 <mnadeem@redhat.com>
mnadeem92
force-pushed
the
fixing_test_migration_restart
branch
from
55c07c9
to
a3bdfb9
Compare
valaparthvi
approved these changes
Jul 10, 2020
valaparthvi
changed the title
jawatts
approved these changes
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 mnadeem@redhat.com
We can not rely on get_progress_percent as it won't reflect real-time value on GUI and causing the TC to fail, We had a discussion for the same with eng team, some time back and decided to go with time elapsed process during disk migration. We have followed the same with cancel migration test case also.
{{ pytest: cfme/tests/v2v/test_v2v_migrations_single_vcenter.py -k "test_migration_restart" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 }}