This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] Fix RHV44 iso service catalogs #10277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 30, 2020 15:37
The test cfme/tests/infrastructure/test_pxe_provisioning.py::test_pxe_provision_from_template[rhv44] was failing because the former RHEL used for installation was RHEL 6.9 -- incompatible with Virtio network in RHV44
jarovo
changed the title
jarovo
changed the title
jarovo
changed the title
jarovo
changed the title
mshriver
reviewed
Aug 3, 2020
| @@ -93,7 +96,28 @@ def catalog_item(appliance, provider, dialog, catalog, provisioning): | |||
| ) | |||
|
|
|||
|
|
|||
| # There is a Libvirt bug BZ(1783355) on our RHV 4.4. This seem to prevent some tests to run with it. | |||
There was a problem hiding this comment.
@JaryN interesting approach here, but I think we would be fine using this BZ as a blocker directly.
Yes there is a separation from when that BZ is unblocked to when our RHV4.4 provider is updated with the fix, but this test going from skipped to failing is a good indicator that its time to update our provider to pickup the BZ fix.
|
I detected some fixture changes in commit a937fad The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
approved these changes
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with supporting the RHEL we are (still) using for RHV4.3 tests, so I prepared a kickstart template for testing with RHEL 8. There were slight differences to rhel <8 template.
Add blocker as our RHV 44 suffers from bug in libvirt preventing to start the VM this test requires.
{pytest: 'cfme/tests/services/test_iso_service_catalogs.py' --use-provider complete --long-running --long-running -v}
Note we may get rid of the old RHEL altogether. IIRC some changes to yamls are needed for this.