Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[RFR] Add module-scoped replicated_appliances fixture #10312

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[RFR] Add module-scoped replicated_appliances fixture #10312

merged 1 commit into from
Sep 10, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Sep 3, 2020

Added module-scoped multi-region appliance fixture replicated_appliances_modscope, and replaced the function-scoped with this new module-scoped fixture in the tests in cfme/tests/distributed/test_appliance_replication.py. Because the tests previously didn't have to worry about cleanup, I've also added some finalizers to remove provider and other records after each test.

{{ pytest: --long-running --use-provider complete -k 'test_replication_ or test_appliance_replicate_' cfme/tests/distributed/test_appliance_replication.py }}

@dajoRH
Copy link
Contributor

dajoRH commented Sep 4, 2020

I detected some fixture changes in commit e747dbc

The global fixture temp_appliance_preconfig_funcscope_rhevm was changed, but I didn't find where it's used.
The global fixture temp_appliance_preconfig_modscope_rhevm was changed, but I didn't find where it's used.
The global fixture temp_appliance_unconfig_modscope_rhevm was changed, but I didn't find where it's used.
The global fixture replicated_appliances is used in the following files:

  • cfme/tests/cloud_infra_common/test_retirement.py
    • test_vm_retirement_from_global_region
  • cfme/tests/services/test_service_catalogs_multi_region.py
    • remote_appliance

The global fixture replicated_appliances_modscope is used in the following files:

  • cfme/tests/distributed/test_appliance_replication.py
    • test_appliance_replicate_between_regions
    • test_replication_connect_to_vm_in_region
    • test_appliance_replicate_zones
    • test_appliance_replicate_remote_down

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@tpapaioa tpapaioa changed the title [WIPTEST] Add module-scoped replicated_appliances fixture [RFR] Add module-scoped replicated_appliances fixture Sep 4, 2020
@mshriver mshriver merged commit fd4bf91 into ManageIQ:master Sep 10, 2020
@tpapaioa tpapaioa deleted the add_modscope_multi_appliance_fixtures branch September 11, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants