This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Chargeback reports #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfalesni
reviewed
Jun 1, 2017
cfme/intelligence/chargeback.py
Outdated
| @@ -215,6 +215,21 @@ def create(self): | |||
| view.flash.assert_success_message('Chargeback Rate "{}" was added'.format( | |||
| self.description)) | |||
|
|
|||
| def copy(self, *args, **kwargs): | |||
| view = navigate_to(self, 'Details') | |||
| view.configuration.item_select('Copy this Chargeback Rate') | |||
There was a problem hiding this comment.
This should be a navmazing step instead.
gshefer
force-pushed
the
chargeback_reports
branch
4 times, most recently
from
85852f2
to
b43c4bd
Compare
gshefer
force-pushed
the
chargeback_reports
branch
4 times, most recently
from
3f2e4de
to
946d0e9
Compare
gshefer
force-pushed
the
chargeback_reports
branch
12 times, most recently
from
59dc254
to
c4410d0
Compare
gshefer
force-pushed
the
chargeback_reports
branch
from
c4410d0
to
84a756c
Compare
gshefer
force-pushed
the
chargeback_reports
branch
from
256c608
to
d999211
Compare
gshefer
force-pushed
the
chargeback_reports
branch
2 times, most recently
from
385742b
to
0448e5c
Compare
gshefer
force-pushed
the
chargeback_reports
branch
3 times, most recently
from
6357428
to
8a43acc
Compare
gshefer
force-pushed
the
chargeback_reports
branch
from
8a43acc
to
a014d8c
Compare
|
Damn, this has been on RFR for way too long - sorry! What's the newest here? How can I help move this forward? |
|
@jkrocil AFAICS we can merge this :-) |
otsuman
approved these changes
Oct 19, 2017
jkrocil
approved these changes
Oct 19, 2017
|
Let me know if I can help wrt performance @gshefer. I believe the llst time we spoke about this it still wasn't ideal. |
|
@jkrocil cool - thanks. |
|
Sweet! Glad to hear 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
There results could be found in Jenkins (privately)