Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota #8080

Merged
merged 3 commits into from Nov 28, 2018

Conversation

ganeshhubale
Copy link
Member

@ganeshhubale ganeshhubale commented Nov 5, 2018

  • This test case verifies the quota assigned by automation method for user and group
    is working correctly for the infra providers by ordering catalog bundle.
  • Added new fixture
    • catalog bundle()
      • catalog_item_list : this is used to add more than one catalog items to list and pass them to catalog bundle.
      • Here in this test, only one catalog item is created and it is passed to add in catalog bundle.
      • catalog_item_list is taken because list of catalog items are accepted by catalog bundle's create method

{{ pytest: cfme/tests/infrastructure/test_quota_tagging.py -k 'test_quota_catalog_bundle_infra' -v }}

 - This test case verifies the quota assigned by automation method for user and group
   is working correctly for the infra providers by ordering catalog bundle.
@ganeshhubale ganeshhubale changed the title Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the asigned quota [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the asigned quota Nov 5, 2018
@ganeshhubale ganeshhubale changed the title [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the asigned quota [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 5, 2018
@ganeshhubale ganeshhubale changed the title [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 5, 2018
@sshveta
Copy link
Contributor

sshveta commented Nov 7, 2018

Please run this test from SUI context as well.

cfme/services/catalogs/catalog_items/catalog_bundles.py Outdated Show resolved Hide resolved
catalog_item_list.append(catalog_item)
collection = appliance.collections.catalog_bundles
catalog_bundle = collection.create(name='test_{}'.format(fauxfactory.gen_alphanumeric()),
catalog_items=catalog_item_list,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catalog_items=[catalog_item.name]
No need for catalog_item_list = [] if there is only one catalog item

cfme/tests/infrastructure/test_quota_tagging.py Outdated Show resolved Hide resolved
@sshveta sshveta changed the title [RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [WIP] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 7, 2018
 - Removed  catalog_item_list while creating catalog bundle
@ganeshhubale ganeshhubale changed the title [WIP] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 9, 2018
@ganeshhubale ganeshhubale changed the title [WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 9, 2018
@ganeshhubale
Copy link
Member Author

@sshveta
I have updated this PR with requested changes.
Please take a look at it and let me know if you have any suggestions.
Thank you.

@sshveta sshveta changed the title [RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [1LP][RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 12, 2018
@mshriver mshriver self-assigned this Nov 14, 2018
@mshriver mshriver changed the title [1LP][RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [1LP][WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 14, 2018
@ganeshhubale ganeshhubale changed the title [1LP][WIPTEST] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota [1LP][RFR] Test for Quota with Catalog_bundle: Verifying quota limit by ordering catalog bundle over the assigned quota Nov 16, 2018
@mshriver mshriver merged commit 905102b into ManageIQ:master Nov 28, 2018
@ganeshhubale ganeshhubale deleted the cat-bundle branch November 30, 2018 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants