Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Manual test cleanup and qe-test-coverage test cases #9604

Merged
merged 8 commits into from Nov 19, 2019

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Nov 11, 2019

Purpose or Intent

  • Adding tests

    1. test_widget_generate_content_via_rest - BZ 1761836
    2. test_service_refresh_dialog_fields_default_values - BZ 1730813
    3. test_schedule_automation_request - BZ 1740340
    4. test_update_roles_via_rest_name_change - BZ 1596142
    5. test_compare_vm_from_datastore_relationships - BZ 1733120
  • Removing tests

    1. test_automation_request_task [already automated]
    2. test_date_should_be_change_in_editing_reports_scheduled [already automated]
    3. test_custom_reports_with_timelines

@valaparthvi valaparthvi changed the title [WIP] Manual test cleanup and qe-test-coverage test cases [RFR] Manual test cleanup and qe-test-coverage test cases Nov 15, 2019
@dajoRH dajoRH removed the WIP label Nov 15, 2019
@valaparthvi valaparthvi added manual For things concerning manual test definitions test-cleanup Test removal, collection changes, re-organization labels Nov 15, 2019
@john-dupuy john-dupuy changed the title [RFR] Manual test cleanup and qe-test-coverage test cases [1LP][RFR] Manual test cleanup and qe-test-coverage test cases Nov 15, 2019
Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing needs a correction though.

@pytest.mark.manual
@pytest.mark.meta(coverage=[1761836])
@pytest.mark.tier(3)
@pytest.mark.parametrize("implementation", ["UI", "Rest"])
Copy link
Contributor

@izapolsk izapolsk Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUIRED: There are already defined appropriate classes. and please use context instead for better readability
@pytest.mark.parametrize('context', [ViaSSUI, ViaUI])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valaparthvi I think there was a misunderstanding here - there are actual ViaUI / ViaRest classes that should be parametrized against here, and those context classes can be used directly. Your update still just parametrizes the strings.

Example:

@pytest.mark.parametrize('context', [ViaREST, ViaUI])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood that, but um okay here's my question: If I use the classes instead of strings, will I also need to use those contexts? Because I am only using this parametrization so that I know which way to verify my response. Should I stil use the classes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valaparthvi, you aren't required to use these classes in test if it isn't necessary. It will only be used for generating tests.

cfme/tests/test_rest_manual.py Outdated Show resolved Hide resolved
@izapolsk izapolsk self-assigned this Nov 18, 2019
@izapolsk izapolsk changed the title [1LP][RFR] Manual test cleanup and qe-test-coverage test cases [1LP][WIP] Manual test cleanup and qe-test-coverage test cases Nov 18, 2019
@dajoRH dajoRH added the WIP label Nov 18, 2019
@valaparthvi valaparthvi changed the title [1LP][WIP] Manual test cleanup and qe-test-coverage test cases [1LP][RFR] Manual test cleanup and qe-test-coverage test cases Nov 18, 2019
@dajoRH dajoRH removed the WIP label Nov 18, 2019
Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contexts for parametrization should be Via* classes, not strings.

@mshriver mshriver changed the title [1LP][RFR] Manual test cleanup and qe-test-coverage test cases [1LP][WIPTEST] Manual test cleanup and qe-test-coverage test cases Nov 18, 2019
@valaparthvi valaparthvi changed the title [1LP][WIPTEST] Manual test cleanup and qe-test-coverage test cases [1LP][RFR] Manual test cleanup and qe-test-coverage test cases Nov 19, 2019
@izapolsk izapolsk merged commit ab872ef into ManageIQ:master Nov 19, 2019
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
…eIQ#9604)

* Test cleanup

* Add test for BZ 1761836

* Remove unrequired test case

* Add test for BZ 1730813

* Add test for BZ 1730813

* Add test for BZ 1596142

* Add test for BZ 1733120

* Requested changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok manual For things concerning manual test definitions test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants