[1LP][RFR] Manual test cleanup and qe-test-coverage test cases #9604
Conversation
8cdc0b5
to
d9a334d
Compare
db1906e
to
65be736
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing needs a correction though.
cfme/tests/test_rest_manual.py
Outdated
@pytest.mark.manual | ||
@pytest.mark.meta(coverage=[1761836]) | ||
@pytest.mark.tier(3) | ||
@pytest.mark.parametrize("implementation", ["UI", "Rest"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REQUIRED: There are already defined appropriate classes. and please use context
instead for better readability
@pytest.mark.parametrize('context', [ViaSSUI, ViaUI])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valaparthvi I think there was a misunderstanding here - there are actual ViaUI / ViaRest classes that should be parametrized against here, and those context classes can be used directly. Your update still just parametrizes the strings.
Example:
@pytest.mark.parametrize('context', [ViaREST, ViaUI]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that, but um okay here's my question: If I use the classes instead of strings, will I also need to use those contexts? Because I am only using this parametrization so that I know which way to verify my response. Should I stil use the classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valaparthvi, you aren't required to use these classes in test if it isn't necessary. It will only be used for generating tests.
65be736
to
000dcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contexts for parametrization should be Via*
classes, not strings.
000dcc9
to
b74a324
Compare
…eIQ#9604) * Test cleanup * Add test for BZ 1761836 * Remove unrequired test case * Add test for BZ 1730813 * Add test for BZ 1730813 * Add test for BZ 1596142 * Add test for BZ 1733120 * Requested changes
Purpose or Intent
Adding tests
Removing tests