-
Notifications
You must be signed in to change notification settings - Fork 164
[1LP][RFR] Fix tests: test_advanced_search.py::TestConfigManagement #9664
Conversation
03b8bcc
to
d717f4b
Compare
I detected some fixture changes in commit f5324bc53c662e54cf39dcfaac40eed0ee4a01c2 Show fixturesThe local fixture
The local fixture
The local fixture
The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
f5324bc
to
47379a8
Compare
47379a8
to
9268d10
Compare
a8f9a7a
to
4ee409c
Compare
4 flaky tests failed on timeout, on the same line of code in the test. It wouldn't be a bad idea to look into that as it consumes a lot of time to verify.
[Edit https://bugzilla.redhat.com/show_bug.cgi?id=1803947 - bug mentioned in this BZ might be the cause of flakiness of the tests, a workaround is to always reload before opening advanced search] But these failures are unrelated to changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions, I'm not 100% sure if what I'm suggesting is feasible so feel free to correct me if not 😃
@@ -297,7 +296,6 @@ class TestContainers(object): | |||
|
|||
|
|||
@inject_tests | |||
@pytest.mark.meta(blockers=[GH('ManageIQ/integration_tests:9723')]) | |||
class TestAnsibleTower(object): | |||
params_values = [ | |||
SearchParam('ansible_tower_providers', 'All', 'ansible_tower_explorer_provider', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no longer any ansible_tower_providers
collection. I think these tests should be merged into the TestConfigManagement
class if possible.
4ee409c
to
aa921ff
Compare
aa921ff
to
909c326
Compare
909c326
to
4d24026
Compare
2 tests failed in 5.10 due to timeout. It seems unrelated to this PRoutdatedBug found during fixing these tests:
https://bugzilla.redhat.com/show_bug.cgi?id=1777493
Edit: Waiting for #9317 to be merged first, then this PR will be changedcheck just last commit
Merged Ansible and Satellite classes. "Satellite class" to ConfigManagement class was named ConfigManagement, which was a little bit confusing. Removed 2 tests of landing pages of both ConfigMangement instances, as they were not supposed to be tested and were always skipped anyways.
As I touch module-level pytestmark, I let the whole module to be tested by PRT.
1 failed test case in 5.10 -> TestServices.test_filter_crud[myservices-all] doesn't look to be related to these changes.