Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix tests: test_advanced_search.py::TestConfigManagement #9664

Merged
merged 1 commit into from
May 6, 2020

Conversation

psimovec
Copy link
Contributor

@psimovec psimovec commented Nov 25, 2019

2 tests failed in 5.10 due to timeout. It seems unrelated to this PR outdated

Bug found during fixing these tests:
https://bugzilla.redhat.com/show_bug.cgi?id=1777493

Edit: Waiting for #9317 to be merged first, then this PR will be changed
check just last commit

Merged Ansible and Satellite classes. "Satellite class" to ConfigManagement class was named ConfigManagement, which was a little bit confusing. Removed 2 tests of landing pages of both ConfigMangement instances, as they were not supposed to be tested and were always skipped anyways.

As I touch module-level pytestmark, I let the whole module to be tested by PRT.

1 failed test case in 5.10 -> TestServices.test_filter_crud[myservices-all] doesn't look to be related to these changes.

@psimovec psimovec changed the title [WIPTEST] Fix tests: TestConfigManagement [RFR] Fix tests: TestConfigManagement Nov 26, 2019
@psimovec psimovec changed the title [RFR] Fix tests: TestConfigManagement [WIPTEST] Fix tests: TestConfigManagement Nov 27, 2019
@psimovec psimovec changed the title [WIPTEST] Fix tests: TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement Nov 28, 2019
@psimovec psimovec changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [WIP] Fix tests: test_advanced_search.py::TestConfigManagement Nov 28, 2019
@dajoRH dajoRH added WIP and removed WIP-testing labels Nov 28, 2019
@psimovec psimovec changed the title [WIP] Fix tests: test_advanced_search.py::TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement Nov 29, 2019
@dajoRH
Copy link
Contributor

dajoRH commented Nov 29, 2019

I detected some fixture changes in commit f5324bc53c662e54cf39dcfaac40eed0ee4a01c2

Show fixtures

The local fixture config_system is used in the following files:

  • cfme/tests/infrastructure/test_config_management.py
    • test_config_system_tag
    • test_config_system_reprovision

The local fixture authentications is used in the following files:

  • cfme/tests/infrastructure/test_config_management_rest.py
    • _check_edited_authentications
    • test_query_authentications_attributes
    • test_authentications_edit_single
    • test_authentications_edit_multiple
    • test_delete_authentications_from_detail_post
    • test_delete_authentications_from_detail_delete
    • test_delete_authentications_from_collection

The local fixture config_manager_rest is used in the following files:

  • cfme/tests/infrastructure/test_config_management_rest.py
    • test_config_manager_create_rest
    • test_config_manager_edit_rest
    • test_config_manager_delete_rest

The local fixture ansible_workflow_catitem is used in the following files:

  • cfme/tests/services/test_ansible_workflow_servicecatalogs.py
    • test_tower_workflow_item
    • test_retire_ansible_workflow

The local fixture catalog_item is used in the following files:

  • cfme/tests/services/test_config_provider_servicecatalogs.py
    • test_order_tower_catalog_item
    • test_retire_ansible_service

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH dajoRH added WIP-testing and removed WIP labels Nov 29, 2019
@dajoRH dajoRH changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [WIP] Fix tests: test_advanced_search.py::TestConfigManagement Dec 10, 2019
@psimovec psimovec changed the title [WIP] Fix tests: test_advanced_search.py::TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement Dec 19, 2019
@psimovec psimovec force-pushed the fix_testconfigmanagement branch 2 times, most recently from a8f9a7a to 4ee409c Compare January 31, 2020 08:51
@psimovec
Copy link
Contributor Author

psimovec commented Jan 31, 2020

4 flaky tests failed on timeout, on the same line of code in the test. It wouldn't be a bad idea to look into that as it consumes a lot of time to verify.
My guesses what could be

  • too low timeout - fixed 10 seconds in the fill method of View
  • too slow is_displayed property of related View objects

[Edit https://bugzilla.redhat.com/show_bug.cgi?id=1803947 - bug mentioned in this BZ might be the cause of flakiness of the tests, a workaround is to always reload before opening advanced search]

But these failures are unrelated to changes in this PR.

@psimovec psimovec changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [RFR] Fix tests: test_advanced_search.py::TestConfigManagement Jan 31, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, I'm not 100% sure if what I'm suggesting is feasible so feel free to correct me if not 😃

cfme/infrastructure/config_management/satellite.py Outdated Show resolved Hide resolved
@@ -297,7 +296,6 @@ class TestContainers(object):


@inject_tests
@pytest.mark.meta(blockers=[GH('ManageIQ/integration_tests:9723')])
class TestAnsibleTower(object):
params_values = [
SearchParam('ansible_tower_providers', 'All', 'ansible_tower_explorer_provider',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no longer any ansible_tower_providers collection. I think these tests should be merged into the TestConfigManagement class if possible.

@psimovec psimovec changed the title [RFR] Fix tests: test_advanced_search.py::TestConfigManagement [WIP] Fix tests: test_advanced_search.py::TestConfigManagement Feb 7, 2020
@dajoRH dajoRH added the WIP label Feb 7, 2020
@psimovec psimovec changed the title [WIP] Fix tests: test_advanced_search.py::TestConfigManagement [RFR] Fix tests: test_advanced_search.py::TestConfigManagement Feb 17, 2020
@dajoRH dajoRH removed the WIP label Feb 17, 2020
@john-dupuy john-dupuy changed the title [RFR] Fix tests: test_advanced_search.py::TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement Feb 26, 2020
@dajoRH dajoRH changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [WIP] Fix tests: test_advanced_search.py::TestConfigManagement Mar 31, 2020
@psimovec psimovec changed the title [WIP] Fix tests: test_advanced_search.py::TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@psimovec psimovec changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [RFR] Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@psimovec psimovec changed the title [RFR] Fix tests: test_advanced_search.py::TestConfigManagement [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@psimovec psimovec changed the title [WIPTEST] Fix tests: test_advanced_search.py::TestConfigManagement [RFR Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@psimovec psimovec changed the title [RFR Fix tests: test_advanced_search.py::TestConfigManagement [RFR] Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@dajoRH dajoRH removed the WIP-testing label May 5, 2020
@john-dupuy john-dupuy changed the title [RFR] Fix tests: test_advanced_search.py::TestConfigManagement [1LP][RFR] Fix tests: test_advanced_search.py::TestConfigManagement May 5, 2020
@mshriver mshriver merged commit c0c3b75 into ManageIQ:master May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants